[backport] nixos/containers: create veths if only IPv6 is configured #57899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
requested changes
Mar 20, 2019
There was a problem hiding this comment.
(copied from the review of the original PR)
This does not fix the actual problem. It might add the addresses to the containers network but not to the external interface.
Have a look at what I quickly hacked together on Sunday:
That solved the issue for me on one of the servers I temporarily updated to 19.03/unstable.
This fixes the failing nixos.tests.containers-ipv6 test. Thanks to andir. (cherry picked from commit 552e583)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #57897 for 19.03. Needed for #56826
Things done
nixos.tests.containers-ipv6