Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] nixos/containers: create veths if only IPv6 is configured #57899

Closed
wants to merge 1 commit into from

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 19, 2019

Motivation for this change

Backport of #57897 for 19.03. Needed for #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via nixos.tests.containers-ipv6
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@rnhmjoj rnhmjoj requested a review from infinisil as a code owner March 19, 2019 10:10
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 19, 2019
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(copied from the review of the original PR)

This does not fix the actual problem. It might add the addresses to the containers network but not to the external interface.

Have a look at what I quickly hacked together on Sunday:

andir/nixpkgs@04af592

That solved the issue for me on one of the servers I temporarily updated to 19.03/unstable.

Unverified

This user has not yet uploaded their public signing key.
This fixes the failing nixos.tests.containers-ipv6 test. Thanks to andir.

(cherry picked from commit 552e583)
@rnhmjoj rnhmjoj closed this Mar 25, 2019
@rnhmjoj rnhmjoj deleted the fix-ipv6-back branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants