Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/containers: create veths if only IPv6 is configured #57897

Merged
merged 2 commits into from Mar 24, 2019
Merged

nixos/containers: create veths if only IPv6 is configured #57897

merged 2 commits into from Mar 24, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 19, 2019

Motivation for this change

This fixes the failing nixos.tests.containers-ipv6 test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via nixos.tests.containers-ipv6
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj requested a review from infinisil as a code owner March 19, 2019 10:06
@rnhmjoj rnhmjoj mentioned this pull request Mar 19, 2019
Closed
10 tasks
andir
andir requested changes Mar 20, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the actual problem. It might add the addresses to the containers network but not to the external interface.

Have a look at what I quickly hacked together on Sunday:

andir@04af592

That solved the issue for me on one of the servers I temporarily updated to 19.03/unstable.

@rnhmjoj
nixos/containers: create veths if only IPv6 is configured
552e583 
This fixes the failing nixos.tests.containers-ipv6 test. Thanks to andir.
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 23, 2019

ping

@andir
nixos/release: make ipv6 tests as important as legacy IP tests
862615b 
IPv6 container support broke a while ago and we didn't notice it. Making
them part of the (small) release test set should fix that. At this point
in time they should be granted the same amount of importance as the
legacy IP tests.
andir
andir approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I added the tests to both test sets so we can be sure they will be noticed once they fail (again).

@andir
Copy link
Member

andir commented Mar 24, 2019

Merging since I built the nixos-small release successfully.

@andir andir merged commit af27dbf into NixOS:master Mar 24, 2019
@andir andir mentioned this pull request Mar 24, 2019
Merged
10 tasks
@rnhmjoj rnhmjoj deleted the fix-ipv6 branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @andir @GrahamcOfBorg