Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

la-capitaine-icon-theme: init at 0.6.1 #58064

Closed
wants to merge 1 commit into from
Closed

la-capitaine-icon-theme: init at 0.6.1 #58064

wants to merge 1 commit into from

Conversation

LinArcX
Copy link
Contributor

@LinArcX LinArcX commented Mar 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace reviewed Mar 21, 2019
View reviewed changes
pkgs/data/icons/la-capitaine-icon-theme/default.nix
};

postPatch = ''
rm configure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this project had a proper Makefile, etc.

Looks like people had to do some interesting things to package the variants.
https://copr-dist-git.fedorainfracloud.org/cgit/tcg/themes/la-capitaine-icon-theme.git/tree/la-capitaine-icon-theme.spec#n69

Copy link
Contributor Author

@LinArcX LinArcX Mar 22, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it Ok?
https://github.com/LinArcX/la-capitaine-icon-theme/tree/add-meson
If yes i can PR them to merge this and then polish default.nix like moka.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it would install a subdirectory La-Capitaine to the correct location but the organization in tree wouldn't work for that. There's also functionality within the configure script (variants) which is missing.

However you can use a custom install phase for this package for now, and then pr them with your change. Hope I didn't give the impression that was necessary.

@worldofpeace worldofpeace mentioned this pull request Mar 21, 2019
Open
@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@auroraanna
Copy link
Contributor

@LinArcX why didn't you respond to the suggestions? I recommend you update your fork and get this done.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 31, 2022
@romildo
Copy link
Contributor

romildo commented Mar 31, 2022

la-capitaine-icon-theme has been added to nixpkgs in #146163

@LinArcX
Copy link
Contributor Author

LinArcX commented Mar 31, 2022

I don't use nixos for a while and i don't like to be notified anymore. Please don't mention me!

@LinArcX LinArcX closed this Mar 31, 2022
@LinArcX LinArcX deleted the la-capitaine-icon-theme branch March 31, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LinArcX @auroraanna @romildo @worldofpeace @ryantm @GrahamcOfBorg