Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffsend: 0.2.36 -> 0.2.38 #57941

Merged
merged 1 commit into from Mar 21, 2019
Merged

ffsend: 0.2.36 -> 0.2.38 #57941

merged 1 commit into from Mar 21, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

Also add support for xclip on Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Docker using nixos/nix image)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested both Darwin and (using Docker) Linux. The Linux version was tested without an X11 server, but I got the expected "Error: Can't open display: (null)" output from xclip when running ./result/bin/ffsend u -c foo so it seems to have invoked xclip correctly.

@lilyball
ffsend: 0.2.36 -> 0.2.38
59fdbac 
Also add support for xclip on Linux.
@dtzWill dtzWill mentioned this pull request Mar 21, 2019
Closed
10 tasks
@dywedir
Copy link
Member

dywedir commented Mar 21, 2019

Thanks!

@dywedir dywedir merged commit 059349e into NixOS:master Mar 21, 2019
@lilyball lilyball deleted the ffsend branch March 22, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @dywedir @GrahamcOfBorg