Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mopidy-iris: 3.32.5 -> 3.33.0 #57922

Merged
merged 2 commits into from Mar 20, 2019
Merged

mopidy-iris: 3.32.5 -> 3.33.0 #57922

merged 2 commits into from Mar 20, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 19, 2019 •
edited by worldofpeace

Motivation for this change

Fixes #56940

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Tomahna @worldofpeace

@dotlambda dotlambda requested a review from FRidh as a code owner March 19, 2019 21:55
@dotlambda dotlambda mentioned this pull request Mar 19, 2019
Closed
worldofpeace
worldofpeace reviewed Mar 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they just removed the problematic dependencies.

Can you reference these commits in the commit msg for Iris?
jaedb/Iris@c9861bc
jaedb/Iris@4d64980
jaedb/Iris@0c13445
jaedb/Iris@28b5f69

Didn't see them keeping much of a change log.

Other than that this should be fine

Robert Schütz added 2 commits March 19, 2019 23:35
@dotlambda
Copy link
Member Author

Other than that this should be fine

Unless you actually tried running it, I'd like to wait for feedback by a user.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 19, 2019
@worldofpeace
Copy link
Contributor

Other than that this should be fine

Unless you actually tried running it, I'd like to wait for feedback by a user.

Note an explicit approval wouldn't have been in the format of a comment.

@Tomahna
Copy link
Contributor

Tomahna commented Mar 20, 2019

As far as I can tell it works fine. I'm not a user of lastFM though.

@dotlambda dotlambda merged commit f2f577c into NixOS:master Mar 20, 2019
@dotlambda dotlambda deleted the mopidy-iris-3.33.0 branch March 21, 2019 09:31
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @worldofpeace @Tomahna @samueldr @GrahamcOfBorg