Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero-gui: fix missing qml imports #57921

Merged
merged 1 commit into from Mar 27, 2019
Merged

monero-gui: fix missing qml imports #57921

merged 1 commit into from Mar 27, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 19, 2019 •
edited

Motivation for this change

Fix the currently broken monero-gui.
needs #57247

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thedavidmeister thedavidmeister mentioned this pull request Mar 25, 2019
Merged
10 tasks
@rnhmjoj rnhmjoj mentioned this pull request Mar 26, 2019
Closed
@infinisil
Copy link
Member

Can you rebase this on current master such that #57210 is included?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 26, 2019

Done.

@infinisil
Copy link
Member

I get this when I start it:

2019-03-26 23:33:59,733 INFO  [default] Page size: 4096
2019-03-26 23:34:01.830	    7f69f527cc40	WARN 	frontend	src/wallet/api/wallet.cpp:367	app startd (log: /home/infinisil/.cache/monero-project/monero-core/monero-wallet-gui.log)
2019-03-26 23:34:01.853	    7f69f527cc40	WARN 	frontend	src/wallet/api/wallet.cpp:367	Qt:5.12.0 | screen: 2560x1440 - dpi: 96.2922 - ratio:0.849972
2019-03-26 23:34:06.665	    7f69f527cc40	WARN 	frontend	src/wallet/api/wallet.cpp:367	QQmlApplicationEngine failed to load component
2019-03-26 23:34:06.665	    7f69f527cc40	WARN 	frontend	src/wallet/api/wallet.cpp:367	qrc:/main.qml:1544 Type WizardMain unavailable
qrc:/wizard/WizardMain.qml:264 Type WizardWelcome unavailable
qrc:/wizard/WizardWelcome.qml:30 module "QtQuick.XmlListModel" is not installed

2019-03-26 23:34:06.665	    7f69f527cc40	ERROR	frontend	src/wallet/api/wallet.cpp:371	Error: no root objects

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 27, 2019 •
edited

It works for me: it must be picking it up somewhere in my PATH.
I'll check for other missing dependencies.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 27, 2019

Ok, done. It now seems to run in a clean environment.

@infinisil infinisil merged commit a921f8a into NixOS:master Mar 27, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 27, 2019

Thank you!

@rnhmjoj rnhmjoj deleted the monero branch March 28, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @infinisil @GrahamcOfBorg