pythonPackages.elasticsearch-curator: pass "click" dependency in version 6.7 #58023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2019 10:05
…t is incompatible with version 7.0
dotlambda
reviewed
Mar 21, 2019
| @@ -1809,7 +1809,9 @@ in { | |||
| # alias | |||
| elasticsearchdsl = self.elasticsearch-dsl; | |||
|
|
|||
| elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { }; | |||
| elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { | |||
| click = callPackage ../development/python-modules/click { version = "6.7"; }; | |||
There was a problem hiding this comment.
We can't do that for Python packages as multiple versions of the same package can't be in $PYTHONPATH.
There was a problem hiding this comment.
We could use packageOverrides if elasticsearch-curator was only an application. However, according to https://github.com/elastic/curator#curator-api-documentation it also has an API.
There was a problem hiding this comment.
:( That's the end of my python knowledge, tbh. I only use the module, which use elastic-curator as an application:
.. So I'd be fine with packageOverride or simply wrapping the binary, but I don't know what other usecases for this package that would destroy.
|
Sorry, I missed that issue. I'll take a look later if it's not done by
then.
…On Thu, Mar 21, 2019, 11:03 Johan Thomsen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/top-level/python-packages.nix
<#58023 (comment)>:
> @@ -1809,7 +1809,9 @@ in {
# alias
elasticsearchdsl = self.elasticsearch-dsl;
- elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { };
+ elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator {
+ click = callPackage ../development/python-modules/click { version = "6.7"; };
:( That's the end of my python knowledge, tbh. I only use the module,
which use elastic-curator as an application:
https://github.com/NixOS/nixpkgs/blob/be1c03ddaf867e9a58499cd790d5cd72cffc6fca/nixos/modules/services/search/elasticsearch-curator.nix#L89
.. So I'd be fine with packageOverride or simply wrapping the binary, but I
don't know what other usecases for this package that would destroy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58023 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANY4pznC_ccV2njtR-hzZc3-b2pKTqFks5vY1jVgaJpZM4cA_X5>
.
|
dotlambda
pushed a commit
to dotlambda/nixpkgs
that referenced
this pull request
Mar 21, 2019
See NixOS#58023 for a discussion of why this is necessary. The upstream issue can be found at elastic/curator#1280.
10 tasks
srhb
pushed a commit
to srhb/nixpkgs
that referenced
this pull request
Mar 22, 2019
See NixOS#58023 for a discussion of why this is necessary. The upstream issue can be found at elastic/curator#1280. (cherry picked from commit c0409de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Improving the fix from #57912 by passing click in version 6.7 to elasticsearch-curator, since according to elastic/curator#1280, it is not compatible with click v7.0.
This should be backported to 19.03 as well.
cc @srhb @dotlambda
@GrahamcOfBorg build pythonPackages.elasticsearch-curator pythonPackages.click
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)