Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstackImage: set the / fsType to reenable root FS resizing #58024

Merged
merged 1 commit into from Mar 22, 2019
Merged

openstackImage: set the / fsType to reenable root FS resizing #58024

merged 1 commit into from Mar 22, 2019

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Mar 21, 2019

Since 34234dc, the reisizefs tool is
embeded only if the fsType starts with ext. The default fsType
value is auto.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nlewo
openstackImage: set the / fsType to reenable root FS resizing
f116d04 
Since 34234dc, the reisizefs tool is
embeded only if the `fsType` starts with `ext`. The default `fsType`
value is `auto`.
@nlewo nlewo requested a review from infinisil as a code owner March 21, 2019 09:18
@nlewo nlewo merged commit 715365e into NixOS:master Mar 22, 2019
@nlewo
Copy link
Member Author

nlewo commented Mar 22, 2019

Backported in 19.03 a25ad68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlewo @GrahamcOfBorg