Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.joblib: 0.12.4 -> 0.13.2 #57906

Merged
merged 1 commit into from Mar 24, 2019
Merged

python.pkgs.joblib: 0.12.4 -> 0.13.2 #57906

merged 1 commit into from Mar 24, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 19, 2019 •
edited

Motivation for this change

https://hydra.nixos.org/build/90115526

closes #57176

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @sveitser @FlorianFranzen

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 19, 2019
@dotlambda dotlambda requested a review from FRidh as a code owner March 19, 2019 14:52
@sveitser
Copy link
Contributor

There's another open PR for this update: #57176

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.joblib python3.pkgs.joblib

@dotlambda dotlambda mentioned this pull request Mar 20, 2019
Closed
10 tasks
@veprbl
Copy link
Member

veprbl commented Mar 23, 2019

cc @costrouc

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.joblib python3.pkgs.joblib

2 similar comments
@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.joblib python3.pkgs.joblib

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.joblib python3.pkgs.joblib

@dotlambda
Copy link
Member Author

@grahamc I think ofborg is broken.

@dotlambda dotlambda merged commit 2c07a08 into NixOS:master Mar 24, 2019
@dotlambda dotlambda deleted the joblib-0.13.2 branch March 24, 2019 08:32
dotlambda added a commit that referenced this pull request Mar 24, 2019
@dotlambda
python.pkgs.joblib: 0.12.4 -> 0.13.2 (#57906)
9965ac0 
(cherry picked from commit 2c07a08)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @sveitser @veprbl @samueldr @GrahamcOfBorg