Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neocomp: init at 2019-03-12 #58037

Merged
merged 1 commit into from Jun 11, 2019
Merged

neocomp: init at 2019-03-12 #58037

merged 1 commit into from Jun 11, 2019

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Mar 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Twey Twey force-pushed the neocomp-2019-03-12 branch 4 times, most recently from c26ca15 to cfe3c19 Compare March 21, 2019 13:43
@Twey Twey changed the title NeoComp: init at 2019-03-12 NeoComp: init at v0.6-17-g271e784 Mar 21, 2019
@Twey
Copy link
Contributor Author

Twey commented Mar 21, 2019

Not totally sure about this versioning scheme, but it's what's used internally.

@Twey Twey changed the title NeoComp: init at v0.6-17-g271e784 NeoComp: init at git-v0.6-17-g271e784-2019-03-12 Mar 21, 2019
@Twey Twey changed the title NeoComp: init at git-v0.6-17-g271e784-2019-03-12 neocomp: init at 2019-03-12 Mar 22, 2019
@Twey
Copy link
Contributor Author

Twey commented May 9, 2019

Bump!

@matthewbauer matthewbauer merged commit 123d61c into NixOS:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Twey @dtzWill @matthewbauer @GrahamcOfBorg