Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persepolis: init at 3.1.0 #58051

Merged
merged 1 commit into from Apr 13, 2019
Merged

persepolis: init at 3.1.0 #58051

merged 1 commit into from Apr 13, 2019

Conversation

LinArcX
Copy link
Contributor

@LinArcX LinArcX commented Mar 21, 2019 •
edited

Motivation for this change

It is one the best gui download manager in linux world. :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

@LinArcX I built your branch and ran it. I opened and closed the help dialog (via the window managers close button) which caused the application to crash. Same thing for preferences. Did that happen for you as well?

@LinArcX
Copy link
Contributor Author

LinArcX commented Mar 24, 2019

@aanderse No. After last change I test it locally. It's work like a charm now.
Also I've downloaded some musics with it to test its functionality. It's OK.

aanderse
aanderse approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played around a bit more and it only crashes when I use the window manager to close... so I'll assume that is a window manager issue? LGTM 👍

@LinArcX
Copy link
Contributor Author

LinArcX commented Mar 25, 2019

Nice. Also I've tested it in i3. Without any problems.
So what is next step? :)

@LinArcX
persepolis: init at 3.1.0
128f616 
persepolis: init at 3.1.0

persepolis: init at 3.1.0
@xeji xeji merged commit c023dd9 into NixOS:master Apr 13, 2019
@LinArcX LinArcX mentioned this pull request Apr 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LinArcX @aanderse @jtojnar @GrahamcOfBorg @xeji