Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdImage: use findmnt to get root device when resizing #58059

Merged
merged 1 commit into from Sep 20, 2019
Merged

sdImage: use findmnt to get root device when resizing #58059

merged 1 commit into from Sep 20, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

when testing on an ARM board, /dev/disks/by-label wasn't available during this time in the boot process, (maybe I'm doing something wrong, but it did become available later during boot). this uses findmnt which seems more robust. it also specifies that the script exits on error (therefore trying again on the next boot) and logs commands to the console for clarity.

I've tested it and / is successfully resized on first boot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from dezgeg March 21, 2019 15:58
@illegalprime
Copy link
Member Author

bump
cc @dezgeg @infinisil

infinisil
infinisil approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /dev/disk symlinks indeed are only available once udev is started which could take a bit of time. This sounds like a reasonable change, I'll merge.

@infinisil infinisil merged commit f47ef8f into NixOS:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@illegalprime @infinisil @GrahamcOfBorg