Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh: don't export HISTFILE and friends #58055

Merged
merged 1 commit into from Mar 22, 2019
Merged

zsh: don't export HISTFILE and friends #58055

merged 1 commit into from Mar 22, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 21, 2019

Motivation for this change

Just set them normally.
Exporting them will propagate them to all executed programs
such as bash (as used by nix-shell or nix run),
and badness ensues when different formats are used.

Add comment to avoid this in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
zsh: don't export HISTFILE and friends
173f79f 
Just set them normally.
Exporting them will propagate them to all executed programs
such as bash (as used by nix-shell or nix run),
and badness ensues when different formats are used.
@dtzWill dtzWill requested a review from infinisil as a code owner March 21, 2019 15:29
@Mic92 Mic92 merged commit e6ad7ee into NixOS:master Mar 22, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 22, 2019

I remember that I did the very same fix at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Mic92 @GrahamcOfBorg