Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] nixos/tests/predictable-interfaces: fix failure on aarch64 #57929

Merged
merged 1 commit into from
Mar 27, 2019
Merged

[backport] nixos/tests/predictable-interfaces: fix failure on aarch64 #57929

merged 1 commit into from
Mar 27, 2019
+1 −2

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 19, 2019 •
edited
Loading

Motivation for this change

Backport fix for #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via nixosTeste.predictable-interface-names.*
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Explanation: on aarch64 the interfaces is called enp3s0 instead of ens3, for some reason. Since the "predictable" naming scheme may be deterministic but not that predictable, to avoid future failure (new architectures or changes in qemu) I simply check wheter the traditional scheme (eth*) is used.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 19, 2019
@rnhmjoj rnhmjoj mentioned this pull request Mar 26, 2019
Merged
10 tasks
@flokli flokli merged commit 322ff2f into NixOS:release-19.03 Mar 27, 2019
@flokli
Copy link
Contributor

flokli commented Mar 27, 2019

thanks.

@rnhmjoj rnhmjoj deleted the ifnames-fix-back branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @flokli @GrahamcOfBorg