Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/predictable-interfaces: fix failure on aarch64 #57925

Merged
merged 1 commit into from Mar 26, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 19, 2019

Motivation for this change

Fix a test failure

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via nixosTeste.predictable-interface-names.*
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Explanation: on aarch64 the interfaces is called enp3s0 instead of eth0, for some reason. Since the "predictable" naming scheme may be deterministic but not that predictable, to avoid future failure (new architectures or changes in qemu) I simply check wheter it's the traditional scheme (eth*) is used.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 26, 2019

@matthewbauer Thank you. Did you see #57929? It should be merged as well.

@rnhmjoj rnhmjoj deleted the ifnames-fix branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants