Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: 1.14.1.5488 -> 1.15.1.791 #57928

Merged
merged 1 commit into from Mar 26, 2019
Merged

plex: 1.14.1.5488 -> 1.15.1.791 #57928

merged 1 commit into from Mar 26, 2019

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Mar 19, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rembo10
Copy link
Contributor

rembo10 commented Mar 26, 2019

I think there's another release already (1.15.2.793)

@averelld
Copy link
Contributor Author

Yes, I already updated the PR on the weekend, just didn't adjust the title.

@rembo10
Copy link
Contributor

rembo10 commented Mar 26, 2019

Ah, right, sorry about that! I should have checked closer

bachp
bachp approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works

@LnL7 LnL7 merged commit 018d329 into NixOS:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@LnL7 LnL7 LnL7 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@averelld @rembo10 @bachp @LnL7 @GrahamcOfBorg