Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtpass: 1.2.1 -> 1.2.3 #58075

Merged
merged 1 commit into from Mar 24, 2019
Merged

qtpass: 1.2.1 -> 1.2.3 #58075

merged 1 commit into from Mar 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 21, 2019

Patch no longer needed (seems to be already applied, and notes mention).

Motivation for this change

https://github.com/IJHack/QtPass/releases/tag/v1.2.3
https://github.com/IJHack/QtPass/releases/tag/v1.2.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
qtpass: 1.2.1 -> 1.2.3
f7d2c23 
Patch no longer needed (seems to be already applied, and notes mention).
@teto
Copy link
Member

teto commented Mar 22, 2019

do you know if it fixes the problem where entries are listed but empty once you click on them ? Anyway it's been unusable for months for me so any update is welcome.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 22, 2019 via email

@dotlambda
Copy link
Member

Anyway it's been unusable for months for me so any update is welcome.

In that case, this should be backported.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 22, 2019
@hrdinka hrdinka merged commit 2bc0bf8 into NixOS:master Mar 24, 2019
@hrdinka
Copy link
Contributor

hrdinka commented Mar 24, 2019

Tested locally, thanks! 👍

I'll backport it within the next day (it's currently rebuilding QT…).

@teto I never had this problem, maybe something is wrong with your config

@samueldr
Copy link
Member

samueldr commented Apr 8, 2019

Backported

[release-19.03 89cecf3] qtpass: 1.2.1 -> 1.2.3
Date: Thu Mar 21 15:13:18 2019 -0500
2 files changed, 4 insertions(+), 22 deletions(-)

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @teto @dotlambda @hrdinka @samueldr @GrahamcOfBorg