grub: Add gfxpayload #58027
Merged
grub: Add gfxpayload #58027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielFabian
force-pushed
the
gfxpayload
branch
2 times, most recently
from
af8a72b
to
4dcfb9f
Compare
DanielFabian
requested review from
basvandijk,
Ericson2314,
FRidh,
matthewbauer and
peti
as code owners
DanielFabian
force-pushed
the
gfxpayload
branch
from
4dcfb9f
to
2ecc8d0
Compare
matthewbauer
approved these changes
Mar 23, 2019
DanielFabian
force-pushed
the
gfxpayload
branch
from
2ecc8d0
to
a91ded6
Compare
samueldr
reviewed
Apr 4, 2019
|
Just to be sure, though it ran locally @GrahamcOfBorg test installer.simple installer.simpleUefi Only change I would like is to have the commits squashed into one. Otherwise this looks alright! |
|
The last force-push does the squash. I made it so, that the previous version and this one have binary identical content and differ only in history. So a new round of testing shouldn't be needed. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When dealing with NVIDIA drivers, you end up with bad resolution in terminal-only mode. This can be fixed by setting
gfxpayloadtokeep. However, the package currently hard codestextfor BIOS. This change should be fully backwards-compatible and just introduces a place override the behaviour.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)