Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus: fix version 2 errors #57910

Closed
wants to merge 1 commit into from
Closed

prometheus: fix version 2 errors #57910

wants to merge 1 commit into from

Conversation

shmish111
Copy link
Contributor

@shmish111 shmish111 commented Mar 19, 2019 •
edited

Motivation for this change

if package was set to prometheus_2 then some commands in the derivation were wrong

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@shmish111
prometheus: fix version 2 errors
f67d321 
if package was set to prometheus_2 then some commands in the derivation
were wrong
@shmish111
Copy link
Contributor Author

Currently running this on a NixOS machine.

@jbgi
Copy link
Contributor

jbgi commented Mar 20, 2019

see also: #49802

@shmish111
Copy link
Contributor Author

This is superseded by #58255

@shmish111 shmish111 closed this Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shmish111 @jbgi @GrahamcOfBorg