Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libunity fix build #58050

Merged
merged 2 commits into from Mar 24, 2019
Merged

libunity fix build #58050

merged 2 commits into from Mar 24, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Vala bump in staging broke libunity.
Fixes are already there upstream so it's just an update.

Also noticed dee was out of date so got that too.

Notes

These were switched to fetching from within ubuntu's packaging
https://git.launchpad.net/ubuntu/+source/libunity

I did this because I felt it was more convenient.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
libunity: 2015-10-02 -> 2019-03-19
dea05e3 
Fixes build with newer vala.

Chose to fetch from ubuntu's git packaging because it
is easier for me to maintain. This would be the same
version used in Ubuntu's Disco Dongo.

Changelog: https://git.launchpad.net/ubuntu/+source/libunity/tree/debian/changelog?id=adae0cbb67ee5eb0913e8cd1887e15e72800251f
@worldofpeace
dee: 1.2.7 -> 2017-06-16
dafe2bd 
Changelog: https://bazaar.launchpad.net/~ci-train-bot/dee/dee-ubuntu-artful-2824/view/head:/debian/changelog
jtojnar
jtojnar reviewed Mar 24, 2019
View reviewed changes
pkgs/development/libraries/libunity/default.nix

preConfigure = "NOCONFIGURE=1 ./autogen.sh";
preConfigure = ''
intltoolize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use this? The source code still seems to use gnome-common.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it does. But It doesn't mean I can't do everything to resist that fact 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@worldofpeace worldofpeace merged commit ac1bd5b into NixOS:master Mar 24, 2019
@worldofpeace
Copy link
Contributor Author

Thanks 👍

@worldofpeace worldofpeace deleted the libunity/fix-build branch March 24, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg