Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network-manager: move para about service rename to 19.09 changelog #57938

Merged
merged 1 commit into from Mar 22, 2019
Merged

network-manager: move para about service rename to 19.09 changelog #57938

merged 1 commit into from Mar 22, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 20, 2019

Motivation for this change

Followup of #51382 - the changelog obviously should go into the 19.09 section, as 19.03 has already branched off and this won't land in 19.03.

cc @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from jtojnar March 20, 2019 02:10
@jtojnar
Copy link
Contributor

jtojnar commented Mar 20, 2019

Cannot we backport it instead still?

@worldofpeace
Copy link
Contributor

This really shouldn't be a problematic change since the service is symlinked.
Why not just backport it and keep it in the 19.03 release notes?

@lheckemann Would that be acceptable?

@flokli
Copy link
Contributor Author

flokli commented Mar 22, 2019

TBH, I don't think the symlink workaround has had enough people trying this out - I did try the symlink workaround 4 days ago, then we merged the PR, after the original PR was laying around untouched for 2 months.
So I don't think there's too much pressure on getting this in for 19.03 still.

Better shift it to 19.09, and be safe it doesn't break things so short before the release.
If @lheckemann decides otherwise, we can still move changelogs around, but let's reflect to how things currently are in master.

@flokli flokli merged commit 9aa5790 into NixOS:staging Mar 22, 2019
@flokli flokli deleted the network-manager-rename-changelog branch March 22, 2019 18:18
@worldofpeace worldofpeace mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @jtojnar @worldofpeace @GrahamcOfBorg