Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltips not appearing in some instances. #7389

Merged
merged 3 commits into from Mar 20, 2019
Merged

Fix tooltips not appearing in some instances. #7389

merged 3 commits into from Mar 20, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 20, 2019

@PeterN
Fix OpenTTD#7386: Measurement tooltip for tunnels, aqueducts & docks …
60f176b 
…did not display or flickered.

Measurement tooltip was auto-closed as the hover/right-click test for tooltips was not
satisfied in this case. This is fixed by keeping the tooltip visible and instead explicitly
closing the tooltip when the PlaceObject is cancelled/completed.
@PeterN
Codechange: Implement OnTooltip event for custom window tooltips.
fc16934 
This avoids windows from needing to know or care about tooltip delay settings.
@PeterN
Fix OpenTTD#7384: Industry Chain tooltips did not display on right-cl…
16662d6 
…ick.

This is fixed by handling the new Window::OnTooltip() event instead of OnHover()
@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Mar 20, 2019
@PeterN PeterN merged commit b3ef06f into OpenTTD:master Mar 20, 2019
@PeterN PeterN deleted the tooltips branch March 20, 2019 23:00
@TrueBrain TrueBrain mentioned this pull request Mar 23, 2019
Merged
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michicc michicc michicc approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterN @michicc @TrueBrain