Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlohmann_json: 3.5.0 -> 3.6.1 #57969

Merged
merged 2 commits into from Mar 25, 2019
Merged

nlohmann_json: 3.5.0 -> 3.6.1 #57969

merged 2 commits into from Mar 25, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 20, 2019

Motivation for this change

https://github.com/nlohmann/json/releases/tag/v3.6.0

Note when building, since I was surprised:

  • source tarball is 113MB, 258MB unpacked
  • testing takes a bit, mostly on a single test
    • if it's the unicode test, then just wait, it's not stuck just thorough :)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the title nlohmann_json: 3.5.0 -> 3.6.0 nlohmann_json: 3.5.0 -> 3.6.1 Mar 21, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2019

@GrahamcOfBorg build toxvpn hydra mtxclient cpp-ipfs-api

@dtzWill dtzWill merged commit 0d796ff into NixOS:master Mar 25, 2019
@dtzWill dtzWill deleted the update/nlohmann_json-3.6.0 branch March 25, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg