Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsboat: 2.14 -> 2.14.1 #57971

Merged
merged 1 commit into from Mar 21, 2019
Merged

newsboat: 2.14 -> 2.14.1 #57971

merged 1 commit into from Mar 21, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 20, 2019

Motivation for this change

https://github.com/newsboat/newsboat/blob/master/CHANGELOG.md#2141---2019-02-10

The package fails to build with

    Updating registry `https://github.com/rust-lang/crates.io-index`
error: failed to sync

Caused by:
  failed to load pkg lockfile

Caused by:
  no matching version `= 2.14.0` found for package `libnewsboat` (required by `libnewsboat-ffi`)
location searched: file:///build/newsboat-2.14.1/rust/libnewsboat
versions found: 2.14.1

That's why I added a patch that corrects the versions in Cargo.lock. However, that doesn't seem to be picked up. Can someone experienced with the Rust infrastructure help out?
For reference: https://groups.google.com/d/msg/newsboat/V64yNbmz5U0/QVzHKpVZAwAJ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dywedir
Copy link
Member

dywedir commented Mar 21, 2019

Thank you!

@dywedir dywedir merged commit 1985e76 into NixOS:master Mar 21, 2019
@dotlambda
Copy link
Member Author

Thank you for helping out with Rust!

@dotlambda dotlambda deleted the newsboat-2.14.1 branch March 21, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants