llvmPackages_8: rc5 -> 8.0.0 release! #57970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c6f434c
approved these changes
Mar 20, 2019
matthewbauer
approved these changes
Mar 20, 2019
pkgs/top-level/all-packages.nix
Outdated
| @@ -6899,7 +6900,7 @@ in | |||
|
|
|||
| crossLibcStdenv = overrideCC stdenv | |||
| (if stdenv.targetPlatform.useLLVM or false | |||
| then buildPackages.llvmPackages_7.lldClangNoLibc | |||
| then buildPackages.llvmPackages_8.lldClangNoLibc | |||
There was a problem hiding this comment.
Do you think a version makes sense here? Not sure how to handle it, but I would prefer if just used the "stable" llvmPackages. I guess we can do that later once everything is on llvm 8.
There was a problem hiding this comment.
That's to be as close to gcc as possible.
There was a problem hiding this comment.
(dropping this change, can revisit later as you say :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Released!
http://releases.llvm.org/
https://lists.llvm.org/pipermail/llvm-announce/2019-March/000082.html
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Various llvm/clang users may wish to upgrade,
but there are many so leaving them as-is for now.
Still building some variants, but will be done in a few...