elasticsearch-curator: add top-level package using older click #58031
Conversation
See NixOS#58023 for a discussion of why this is necessary. The upstream issue can be found at elastic/curator#1280.
dotlambda
added
the
9.needs: port to stable
|
Thank you for this, and sorry about the trouble. I'm a bit worried about the downstream builds from this though, is there any way we can avoid it on the default click? |
Yes, if we override
I wouldn't worry about the rebuilds though: |
|
Oh, I'm only talking about the amount of rebuilds, not that I'm scared anything broke from this. nox-review produced quite a list. |
|
I see. That's usually not that big of a deal for Python packages as they are relatively cheap to build. |
| }; | ||
| }); | ||
| }; | ||
| }).pkgs; toPythonApplication elasticsearch-curator; |
There was a problem hiding this comment.
Minor nitpick. toPythonApplication could be put into packageOverrides. This would remove usage of with:
elasticsearch-curator = let
packageOverrides = self: super: {
elasticsearch-curator = super.toPythonApplication super.elasticsearch-curator;
click = super.click...
};
customPythonPackages = (python3.overrde { inherit packageOverrides; }).pkgs;
in
customPythonPackages.elasticsearch-curator;
It looks kinda miracle, that elasticsearch-curator didn't select self.elasticsearch-curator from outer scope...
samueldr
removed
the
9.needs: port to stable
Motivation for this change
closes #58023
I'm not sure if this warrants a mention in the release notes.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @johanot @srhb @basvandijk