Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/isync: init #58088

Closed
wants to merge 1 commit into from
Closed

nixos/isync: init #58088

wants to merge 1 commit into from

Conversation

StillerHarpo
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/34

@teto
Copy link
Member

teto commented Aug 5, 2019

I am kind of torn about this one because home-manager already has a module and a config generator for isync.

nixos/modules/services/mail/isync.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/isync.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/isync.nix Show resolved Hide resolved
nixos/modules/services/mail/isync.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/isync.nix Outdated Show resolved Hide resolved
options.services.isync = {
enable = mkEnableOption "Isync, a software to dispose your mailbox(es) as a local Maildir(s)";

install = mkOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused as to why there's both enable and install doing pretty much the same

nixos/modules/services/mail/isync.nix Outdated Show resolved Hide resolved
@Lassulus
Copy link
Member

Lassulus commented Oct 1, 2019

so, anything going on here? maybe an alternate name to install would be sufficient?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@SuperSandro2000
Copy link
Member

Closing due to inactivity. Feel free to reopen the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants