Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoModule: remove SSL env vars in favor of cacert in buildInputs #58082

Merged
merged 1 commit into from Mar 21, 2019
Merged

buildGoModule: remove SSL env vars in favor of cacert in buildInputs #58082

merged 1 commit into from Mar 21, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 21, 2019 •
edited

Motivation for this change

cacert already exposes NIX_SSL_CERT_FILE in its setupHook. Fetchers and builders are already setup to use this variable and there's no need to export them manually.

(cherry picked from commit 6d7d69f)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/backports

@kalbasit
buildGoModule: remove SSL env vars in favor of cacert in buildInputs (N…
9521772 
…ixOS#58071)

cacert already exposes NIX_SSL_CERT_FILE in its setupHook. Fetchers and builders are already setup to use this variable and there's no need to export them manually.

(cherry picked from commit 6d7d69f)
@kalbasit kalbasit requested a review from LnL7 March 21, 2019 21:48
@kalbasit kalbasit merged commit 8373406 into NixOS:release-19.03 Mar 21, 2019
@kalbasit kalbasit deleted the nixpkgs_cacert-as-build-inputs branch March 21, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kalbasit