Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-web: 1.0.3 -> 1.0.5 #58040

Merged
merged 1 commit into from Mar 24, 2019
Merged

riot-web: 1.0.3 -> 1.0.5 #58040

merged 1 commit into from Mar 24, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Mar 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre
Copy link
Member Author

@GrahamcOfBorg build riot-web

@xeji xeji merged commit 62fd641 into NixOS:master Mar 24, 2019
@nyanloutre nyanloutre deleted the riot-update branch March 29, 2019 10:12
fpletz pushed a commit that referenced this pull request Apr 1, 2019
@nyanloutre @fpletz
riot-web: 1.0.3 -> 1.0.5 (#58040)
1f22614 
(cherry picked from commit 62fd641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien pacien approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @pacien @GrahamcOfBorg @xeji