Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautrix-telegram: 0.4.0.post1 -> 0.5.0 #56193

Merged
merged 3 commits into from Mar 20, 2019
Merged

mautrix-telegram: 0.4.0.post1 -> 0.5.0 #56193

merged 3 commits into from Mar 20, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Feb 22, 2019 •
edited

Motivation for this change

The available version is still a release candidate so this PR will be a draft until the stable realease

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre marked this pull request as ready for review March 20, 2019 10:45
@nyanloutre nyanloutre requested a review from FRidh as a code owner March 20, 2019 10:45
@nyanloutre
Copy link
Member Author

Final version is now out and this PR was updated

@dotlambda
Copy link
Member

@GrahamcOfBorg build mautrix-telegram

@dotlambda dotlambda mentioned this pull request Mar 20, 2019
Closed
@dotlambda
Copy link
Member

@GrahamcOfBorg build mautrix-telegram

@Ma27
Copy link
Member

Ma27 commented Mar 20, 2019 •
edited

Btw we should definetely backport this as mautrix-telegram 0.4.0.post1 fails when running mautrix-telegram -g with the following error:

→ ./result/bin/mautrix-telegram -g -c ../mautrix-telegram/config.yaml
Traceback (most recent call last):
  File "/nix/store/k0lgh8g637r35bb6ywl90b7xfyhdak4l-python3.7-mautrix-telegram-0.4.0.post1/bin/.mautrix-telegram-wrapped", line 7, in <module>
    from mautrix_telegram.__main__ import main
  File "/nix/store/k0lgh8g637r35bb6ywl90b7xfyhdak4l-python3.7-mautrix-telegram-0.4.0.post1/lib/python3.7/site-packages/mautrix_telegram/__main__.py", line 31, in <module>
    from .web.provisioning import ProvisioningAPI
  File "/nix/store/k0lgh8g637r35bb6ywl90b7xfyhdak4l-python3.7-mautrix-telegram-0.4.0.post1/lib/python3.7/site-packages/mautrix_telegram/web/__init__.py", line 1, in <module>
    from .provisioning import ProvisioningAPI
  File "/nix/store/k0lgh8g637r35bb6ywl90b7xfyhdak4l-python3.7-mautrix-telegram-0.4.0.post1/lib/python3.7/site-packages/mautrix_telegram/web/provisioning/__init__.py", line 28, in <module>
    from ...user import User
  File "/nix/store/k0lgh8g637r35bb6ywl90b7xfyhdak4l-python3.7-mautrix-telegram-0.4.0.post1/lib/python3.7/site-packages/mautrix_telegram/user.py", line 33, in <module>
    from .abstract_user import AbstractUser
  File "/nix/store/k0lgh8g637r35bb6ywl90b7xfyhdak4l-python3.7-mautrix-telegram-0.4.0.post1/lib/python3.7/site-packages/mautrix_telegram/abstract_user.py", line 25, in <module>
    from telethon.tl.types import (
ImportError: cannot import name 'UpdateChatAdmins' from 'telethon.tl.types' (/nix/store/06amhafx1ahwdcgw6kjkq0qjggim5dyp-python3.7-telethon-1.5.5/lib/python3.7/site-packages/telethon/tl/types/__init__.py)

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 20, 2019
@dotlambda dotlambda merged commit f088866 into NixOS:master Mar 20, 2019
@dotlambda
Copy link
Member

backported in 622bb13, 199a8e7, and 19ad186

@nyanloutre nyanloutre deleted the mautrix-update branch March 20, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nyanloutre @dotlambda @Ma27 @GrahamcOfBorg @r-ryantm