Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweethome3d: 6.0 -> 6.1.2 #58061

Merged
merged 1 commit into from Mar 27, 2019
Merged

sweethome3d: 6.0 -> 6.1.2 #58061

merged 1 commit into from Mar 27, 2019

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Mar 21, 2019

Motivation for this change

Updated to newer version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse reviewed Mar 23, 2019
View reviewed changes
pkgs/applications/misc/sweethome3d/default.nix Outdated
@@ -47,6 +47,7 @@ let

installPhase = ''
mkdir -p $out/bin
ls -lR install/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover from debugging? Meant to be removed?

@aanderse
Copy link
Member

I was able to compile the application. Unfortunately I couldn't confirm the application was properly running because of an unrelated issue I'm having running any java program from unstable currently.

@eyJhb
Copy link
Member Author

eyJhb commented Mar 23, 2019

@aanderse correct, forgot to remove that. It runs fine on mine, I have testing it just using

nix-shell -I nixpkgs=nixpkgs/ -p sweethome3d.application

And then running it. That the application is very slow and almost unuseable in general (even before update), is another thing. :)

@etu etu merged commit 72d29f8 into NixOS:master Mar 27, 2019
@jtojnar jtojnar mentioned this pull request Aug 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eyJhb @aanderse @matthiasbeyer @etu @GrahamcOfBorg