Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Display tooltips on industry chains window even when "Show toolt… #7384

Closed
wants to merge 1 commit into from

Conversation

stormcone
Copy link
Contributor

…ips" is set to right click.

The changes are based on how the "Cargo Flow Legend" window (linkgraph_gui.cpp) works.

@michicc
Copy link
Member

michicc commented Mar 19, 2019

That's surely a Fix:, isn't it?

Please update the commit message (amend/rebase) and force-push to update the PR.

@PeterN
Copy link
Member

PeterN commented Mar 20, 2019

This does not look like the right fix for the problem, which affects multiple instances.

PeterN added a commit to PeterN/OpenTTD that referenced this pull request Mar 20, 2019
…ick.

This is fixed by handling the new Window::OnTooltip() event instead of OnHover()
@stormcone stormcone changed the title Add: Display tooltips on industry chains window even when "Show toolt… Fix: Display tooltips on industry chains window even when "Show toolt… Mar 20, 2019
@stormcone
Copy link
Contributor Author

@michicc: It's maybe a matter of perspective. From the users' point of view it is. From the code's point of view actually there is no bug, because this functionality is just not there, so it's an "add. :) Anyway I modified it, however @PeterN's PR looks more suitable.

@michicc
Copy link
Member

michicc commented Mar 20, 2019

Indeed, the other PR is the better way.

Still, just for completeness: The commit message is for example the basis for the user-visible changelog. As such, especially the prefix should be from the user POV and not the implementation POV.

@PeterN PeterN closed this in #7389 Mar 20, 2019
PeterN added a commit that referenced this pull request Mar 20, 2019
This is fixed by handling the new Window::OnTooltip() event instead of OnHover()
@stormcone stormcone deleted the industry_chain_tooltips branch March 22, 2019 22:33
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Mar 23, 2019
…ick.

This is fixed by handling the new Window::OnTooltip() event instead of OnHover()
TrueBrain pushed a commit that referenced this pull request Mar 24, 2019
This is fixed by handling the new Window::OnTooltip() event instead of OnHover()
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
…ick.

This is fixed by handling the new Window::OnTooltip() event instead of OnHover()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants