Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fonttools: 3.37.3 -> 3.39.0 #57934

Merged
merged 2 commits into from Mar 22, 2019
Merged

pythonPackages.fonttools: 3.37.3 -> 3.39.0 #57934

merged 2 commits into from Mar 22, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner March 20, 2019 00:47
@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2019

https://github.com/fonttools/fonttools/releases/tag/3.38.0
https://github.com/fonttools/fonttools/releases/tag/3.39.0

@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2019

@GrahamcOfBorg build python3Packages.fonttools liberation_ttf_v1 liberation_ttf_v2 noto-fonts

(fonts to check if hashes change, not a fonttools bug if they do but should probably be changed accordingly ^_^)

@dotlambda dotlambda changed the title fonttools; 3.37.3 -> 3.39.0 pythonPackages.fonttools: 3.37.3 -> 3.39.0 Mar 22, 2019
@dotlambda dotlambda merged commit 1903047 into NixOS:master Mar 22, 2019
costrouc referenced this pull request Apr 3, 2019
@costrouc @FRidh
pythonPackages.ipdb: refactor move to python-modules
2750333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @dotlambda @GrahamcOfBorg