Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidating wrong orders #7391

Closed
SamuXarick opened this issue Mar 20, 2019 · 0 comments
Closed

Invalidating wrong orders #7391

SamuXarick opened this issue Mar 20, 2019 · 0 comments

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

1.9.0-RC1

Expected result

Don't invalidate depot orders for road vehicles when building a heliport

Actual result

May invalidate depot orders for road vehicles when building a heliport

Steps to reproduce

autosave3.zip
Load savegame, and pay attention to Road Vehicle 99 order list. On the exact 4th March, a heliport is attached to New Trindwood, which is a bus station and the go to depot orders become invalid.

9b99b95 causes it.
@SamuXarick SamuXarick changed the title 9b99b95955d72e49821fe235c0d6fc1e75dc64b2 Invalidating wrong orders Mar 20, 2019
michicc added a commit to michicc/OpenTTD that referenced this issue Mar 20, 2019
@michicc
Fix OpenTTD#7391, 9b99b95: Don't invalidate go to depot orders of non…
bb287b5 
…-aircraft when invalidating hangar orders that happen to share IDs.

This was caused because hangars are referred to by station ID, which is not unique with respect to depot IDs.
michicc added a commit to michicc/OpenTTD that referenced this issue Mar 20, 2019
@michicc
Fix OpenTTD#7391, 9b99b95: Don't invalidate go to depot orders of non…
fca3c14 
…-aircraft when invalidating hangar orders that happen to share IDs.

This was caused because hangars are referred to by station ID, which is not unique with respect to depot IDs.
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Mar 23, 2019
@michicc @TrueBrain
Fix OpenTTD#7391, 9b99b95: Don't invalidate go to depot orders of non…
5e65482 
…-aircraft when invalidating hangar orders that happen to share IDs.

This was caused because hangars are referred to by station ID, which is not unique with respect to depot IDs.
TrueBrain pushed a commit that referenced this issue Mar 24, 2019
@michicc @TrueBrain
Fix #7391, 9b99b95: Don't invalidate go to depot orders of non-aircra…
e3a082c 
…ft when invalidating hangar orders that happen to share IDs.

This was caused because hangars are referred to by station ID, which is not unique with respect to depot IDs.
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@michicc @douiwby
Fix OpenTTD#7391, 9b99b95: Don't invalidate go to depot orders of non…
d8de745 
…-aircraft when invalidating hangar orders that happen to share IDs.

This was caused because hangars are referred to by station ID, which is not unique with respect to depot IDs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamuXarick