improve the error messages when invalid declarative jobsets are defined #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7568b89)
grahamc
reviewed
Mar 20, 2019
| }; | ||
| if ($@) { | ||
| print STDERR "ERROR: failed to process declarative jobset ", $project->name, ":${jobsetName}, ", $@, "\n"; | ||
| } |
There was a problem hiding this comment.
The old behavior caused the exception from updateDeclarativeJobset to percolate up, and this one prints a warning and swallows it. Is this an intended behavior change?
There was a problem hiding this comment.
If we wanted to preserve the behavior (I sort of suspect, cautiously, that we do), we'd add:
die $@
There was a problem hiding this comment.
there was a declarative jobset, that has invalid parameters on it, and because of the old behavior, one jobset being invalid stopped the entire project from updating
this new behavior makes it capable of updating other jobsets when some are invalid, so the entire project doesnt grind to a total halt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7568b89)
This improves error messages when declarative jobsets are used.