New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cassandra 3.11.3 -> 3.11.4 #58025
cassandra 3.11.3 -> 3.11.4 #58025
Conversation
@GrahamcOfBorg test cassandra |
Looks like the cassandra test may have been removed from |
@aanderse Looks like the only file in the nixos/tests directory contains cassandra is nixos/tests/cassandra.nix. I tried to search cassandra with |
@contrun pardon my poor choice of wording. The actual test remains, but the test is not actually executed by the bot because a reference to the test was removed (or never existed?) in all-tests.nix. Can you please create an additional commit adding the test back into all-tests.nix? |
5516bf5
to
b9a7345
Compare
@aanderse Added that. But I am not familiar with the testing process. Not sure if it will work. |
I've been running the test from the master branch locally for ~10 minutes now and no success. @cransom as the listed maintainer of the cassandra package do you have any information which could help us? |
@GrahamcOfBorg test cassandra |
@JohnAZoidberg as someone interested in cassandra do you have any insight into why the test is not succeeding? |
Seems like you can't have a node as its own seed when it's listening on an interface instead of an IP. I'll push a fix to my PR from yesterday that improves the config file: #59179 |
@contrun Any chance I can get you to leave a review and approval on #59179 if everything looks good to you? Bonus points if you test out the changes in your own configuration and mention results. Once #59179 is merged it seems like you could rebase this PR on master and we could quickly and confidently merge this. Sorry for the hold up so far. |
And if you want you can upgrade the other supported versions we have to their new point release that came out on the same day: https://github.com/apache/cassandra/releases |
This PR can be merged now as there is no blocker anymore, right? 100% relying on you @JohnAZoidberg to tell me whether to push the merge button. @contrun Are you able to rebase on master and possibly update other versions as requested by @JohnAZoidberg? |
also add test to all-test.nix
@GrahamcOfBorg test cassandra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests take too long for OfBorg. They run fine on my machine.
@GrahamcOfBorg build cassandra |
Merging solely based on the good word of @JohnAZoidberg. |
Motivation for this change
update cassandra
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)