Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
num_emerge_threads: Warn of crashes when > 1 (#8357)
  • Loading branch information
paramat authored and nerzhul committed Mar 14, 2019
1 parent 02a2389 commit ee57b63
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
8 changes: 5 additions & 3 deletions builtin/settingtypes.txt
Expand Up @@ -1915,16 +1915,18 @@ emergequeue_limit_diskonly (Limit of emerge queues on disk) int 64
emergequeue_limit_generate (Limit of emerge queues to generate) int 64

# Number of emerge threads to use.
# WARNING: Currently there are multiple bugs that may cause crashes when
# 'num_emerge_threads' is larger than 1. Until this warning is removed it is
# strongly recommended this value is set to the default '1'.
# Empty or 0 value:
# - Automatic selection. The number of emerge threads will be
# - 'number of processors - 2', with a lower limit of 1.
# Any other value:
# - Specifies the number of emerge threads, with a lower limit of 1.
# Warning: Increasing the number of emerge threads increases engine mapgen
# WARNING: Increasing the number of emerge threads increases engine mapgen
# speed, but this may harm game performance by interfering with other
# processes, especially in singleplayer and/or when running Lua code in
# 'on_generated'.
# For many users the optimum setting may be '1'.
# 'on_generated'. For many users the optimum setting may be '1'.
num_emerge_threads (Number of emerge threads) int 1

[Online Content Repository]
Expand Down
8 changes: 5 additions & 3 deletions minetest.conf.example
Expand Up @@ -2994,16 +2994,18 @@
# emergequeue_limit_generate = 64

# Number of emerge threads to use.
# WARNING: Currently there are multiple bugs that may cause crashes when
# 'num_emerge_threads' is larger than 1. Until this warning is removed it is
# strongly recommended this value is set to the default '1'.
# Empty or 0 value:
# - Automatic selection. The number of emerge threads will be
# - 'number of processors - 2', with a lower limit of 1.
# Any other value:
# - Specifies the number of emerge threads, with a lower limit of 1.
# Warning: Increasing the number of emerge threads increases engine mapgen
# WARNING: Increasing the number of emerge threads increases engine mapgen
# speed, but this may harm game performance by interfering with other
# processes, especially in singleplayer and/or when running Lua code in
# 'on_generated'.
# For many users the optimum setting may be '1'.
# 'on_generated'. For many users the optimum setting may be '1'.
# type: int
# num_emerge_threads = 1

Expand Down

0 comments on commit ee57b63

Please sign in to comment.