Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inactive reviewers #14798

Merged
merged 9 commits into from Mar 14, 2019

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Jan 10, 2019

This removes reviewers who have had more than three review requests in the past year but who haven't reviewed anything. Fixes #13702.

Places where this leaves us with no reviewers:

  • css/css-display/run-in (but parent has reviewers, so let's just kill that)
  • css/css-position (very few PRs; @atanassov is the current reviewer)
  • css/css-scrollbars (very few PRs; @tantek is current? maybe +@upsuper?)
  • encrypted-media (very few PRs; @ddorwin is current)
  • feature-policy (very few PRs; @clelland is current)
  • gamepad (very few PRs; @luser is current)

I believe everyone removed here was pinged in #13702 (comment), so I don't think we need to check about anyone except for the above. If the people mentioned above want to remain reviewers, please speak now.

@upsuper
Copy link
Member

upsuper commented Jan 13, 2019

I'm fine for adding me to css-scrollbars.

@bakulf
Copy link
Contributor

bakulf commented Jan 14, 2019

I'm fine to be added as feature-policy reviewer.

@marcoscaceres
Copy link
Contributor

@gsnedders
Copy link
Member Author

OK, so that leaves css/css-position and encrypted-media without reviewers.

@astearns
Copy link
Contributor

You can add me as the css-position reviewer for now.

@gsnedders
Copy link
Member Author

For encrypted-media: @ddorwin, @jrummell-chromium? @cpearce? @jyavenard?

@mounirlamouri
Copy link
Contributor

mounirlamouri commented Jan 15, 2019

For encrypted-media: @ddorwin, @jrummell-chromium? @cpearce? @jyavenard?

Could you swap @ddorwin with @joeyparrish ?

Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for mediacapture-main/ and webrtc/

Copy link
Contributor

@cbiesinger cbiesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for css-flexbox

@gsnedders gsnedders merged commit a5f707c into web-platform-tests:master Mar 14, 2019
@gsnedders gsnedders deleted the inactive-reviewers branch March 14, 2019 16:22
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
This removes reviewers who have had more than three review requests in
the past year but who haven't reviewed anything.

Adds a few extra reviewers based on discussions in the PR thread
looking for reviewers for directories that otherwise would've ended up
with none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet