Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use llvmPackages_7 explicitly for ccls #57565

Merged
merged 1 commit into from Mar 13, 2019
Merged

Use llvmPackages_7 explicitly for ccls #57565

merged 1 commit into from Mar 13, 2019

Conversation

Kaali
Copy link

@Kaali Kaali commented Mar 13, 2019

llvmPackages_latest picks too old LLVM for ccls on macOS. Which breaks
the build.

Motivation for this change

For some reason after merging #56673 llvmPackages_latest behaviour has changed. Instead of using the actual latest version on macOS, it uses a version that has Clang 5.x which is too old for ccls.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Use llvmPackages_7 explicitly for ccls
4c53321 
llvmPackages_latest picks too old LLVM for ccls on macOS. Which breaks
the build.
@Mic92
Copy link
Member

Mic92 commented Mar 13, 2019

Out of interest, what does

$ nix eval '(with import <nixpkgs> {}; llvmPackages_latest.llvm.name)'

return on your machine?

Mic92
Mic92 reviewed Mar 13, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -8589,8 +8589,8 @@ in
};

ccls = callPackage ../development/tools/misc/ccls {
llvmPackages = llvmPackages_latest;
stdenv = llvmPackages_latest.stdenv;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be llvm_8 right now, so this is a downgrade to llvm_7.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe the actual problem is, that it does not work with llvm 8.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. That might actually be it. Maybe the version 5 thing was me misreading build output.

@Kaali
Copy link
Author

Kaali commented Mar 13, 2019

Out of interest, what does

$ nix eval '(with import <nixpkgs> {}; llvmPackages_latest.llvm.name)'

return on your machine?

"llvm-8.0.0rc2" so it actually finds 8. So I guess you are correct above that the problem is with 8. So forcing to 7 is accidentally the right solution to this I guess.

@Mic92 Mic92 merged commit 0139c4b into NixOS:master Mar 13, 2019
@Kaali Kaali deleted the fix-darwin-ccls branch March 19, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kaali @Mic92 @GrahamcOfBorg