Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support international characters in animation worklets. #15843

Merged
merged 1 commit into from Mar 15, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 14, 2019

Code in cc/ is not permitted to use wtf::String. Thus, we perform conversions between wtf::String and std::string. The later is not aware of encodings. This is OK provided a consistent encoding is used for round tripping, where the encoding supports the set of allowed characters. The UTF-8 encoding is adequate for this task and supported by wtf::String.

Bug: 940493
Change-Id: Ie2b994412f502ea11df06713439b8cf8ffedc885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524087
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641278}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Code in cc/ is not permitted to use wtf::String. Thus, we perform conversions between wtf::String and std::string.  The later is not aware of encodings.  This is OK provided a consistent encoding is used for round tripping, where the encoding supports the set of allowed characters.  The UTF-8 encoding is adequate for this task and supported by wtf::String.

Bug: 940493
Change-Id: Ie2b994412f502ea11df06713439b8cf8ffedc885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524087
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641278}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants