Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hakyll: bump pandoc dependency to 2.7 #57587

Merged
merged 1 commit into from Mar 16, 2019
Merged

haskellPackages.hakyll: bump pandoc dependency to 2.7 #57587

merged 1 commit into from Mar 16, 2019

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Mar 13, 2019 •
edited

Motivation for this change

Hakyll build broke when pandoc moved to 2.7.

Things done

Hakyll seems to build with Pandoc 2.7 just fine, so I adapted it's version bounds. For some reason, doJailbreak did not work, so I created a patch.

As I have no access to a darwin machine, I only changed the non-darwin part of the expression.

See also this issue, which reports the issue upstream: jaspervdj/hakyll#691

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.hakyll

@erictapen
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.hakyll

@erictapen erictapen mentioned this pull request Mar 14, 2019
Closed
@peti peti merged commit 17c62c9 into NixOS:master Mar 16, 2019
@erictapen erictapen deleted the hakyll-pandoc-bump branch March 17, 2019 12:46
@endgame
Copy link
Contributor

endgame commented Mar 17, 2019

FYI: doJailbreak doesn't work if dependencies are behind flags.

@erictapen
Copy link
Member Author

FYI: doJailbreak doesn't work if dependencies are behind flags.

I see, thanks for the explanation!

mjhoy added a commit to mjhoy/dotfiles that referenced this pull request Apr 5, 2019
@mjhoy
nixpkgs: fix hakyll broken dependencies
6d5935c 
fix @ NixOS/nixpkgs#57587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erictapen @endgame @peti @GrahamcOfBorg