Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paulstretch: init at version 2.2-2 #57589

Closed
wants to merge 2 commits into from
Closed

paulstretch: init at version 2.2-2 #57589

wants to merge 2 commits into from

Conversation

Zer0-
Copy link
Contributor

@Zer0- Zer0- commented Mar 13, 2019

Motivation for this change

This awesome little program is not in nixpkgs yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zer0-
paulstretch: init at version 2.2-2
793ed26 
This is a neat little program for extreme sound stretching and it was
not in the repo yet.
veprbl
veprbl reviewed Mar 22, 2019
View reviewed changes
pkgs/applications/audio/paulstretch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/paulstretch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/paulstretch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/paulstretch/default.nix Outdated Show resolved Hide resolved
@Zer0-
Implement suggested fixes for pull request
b2ad470 
-punctuation
-move pkgconfig to nativeBuildInputs
-removed importing nixpkgs (mistake)
-use install command for installPhase
@Zer0-
Copy link
Contributor Author

Zer0- commented Mar 23, 2019

@veprbl thank you for reviewing my script! I have pushed the suggested changes.

@veprbl
Copy link
Member

veprbl commented Mar 23, 2019

@GrahamcOfBorg eval

@veprbl veprbl mentioned this pull request Mar 23, 2019
Merged
@veprbl
Copy link
Member

veprbl commented Mar 23, 2019

Merged in e0c3c2e

@Zer0- For future reference: We merge all new changes to master branch first and then backport to release-XX branches. Thank you!

veprbl pushed a commit that referenced this pull request Mar 23, 2019
@Zer0- @veprbl
paulstretch: init at version 2.2-2
0ef73ff 
This is a neat little program for extreme sound stretching and it was
not in the repo yet.

(cherry picked from commit e0c3c2e)

cc #57589 #58191
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 23, 2019
@Zer0-
Copy link
Contributor Author

Zer0- commented Mar 23, 2019

@veprbl Awesome! You could have just told me to rebase to master, I would have done it. I remembered reading in the manual that developing off of master was not a requirement but I guess guess that changed. I will develop against master in the future.

@Zer0- Zer0- closed this Mar 23, 2019
veprbl pushed a commit that referenced this pull request Mar 23, 2019
@Zer0- @veprbl
paulstretch: init at version 2.2-2
3551de0 
This is a neat little program for extreme sound stretching and it was
not in the repo yet.

(cherry picked from commit e0c3c2e)

cc #57589 #58191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zer0- @veprbl @GrahamcOfBorg