IndexedDB cursor.request #15820
IndexedDB cursor.request #15820
Conversation
There was a problem hiding this comment.
Please add test cases for:
- IDBCursorWithValue (i.e. non-key cursor)
- Both cursor types with source from index (test here has object store as source)
- Value of cursor.request not within IDB callback and after transaction has ended. (Should still be valid, but one could imagine a non-conforming implementation that needs to break a reference cycle and nulls it out.)
IndexedDB/idbcursor-request.htm
Outdated
| assert_readonly(cursor, 'request'); | ||
| }); | ||
| }, | ||
| document.title |
IndexedDB/idbcursor-request.htm
Outdated
| const cursor = req.result; | ||
| assert_equals(cursor.request, req, 'cursor.request'); | ||
| assert_readonly(cursor, 'request'); | ||
| }); |
There was a problem hiding this comment.
Haha I did this right in my run through before cameras were on. Oh well.
IndexedDB/idbcursor-request.htm
Outdated
| @@ -0,0 +1,27 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Make this a .any.js test for more coverage?
There was a problem hiding this comment.
... and remove some boilerplate.
|
@inexorabletash done! |
IndexedDB/idbcursor-request.any.js
Outdated
| }), 0); | ||
| }); | ||
|
|
||
| req.transaction.onerror = t.step_func((event) => { |
There was a problem hiding this comment.
This can use t.unreached_func instead for brevity.
There was a problem hiding this comment.
This is what I get for cargo culting the other tests.
Define new |request| attribute on IDBCursor. Discussed in #255 WPT PR ready to land: web-platform-tests/wpt#15820 Implementations pending, but this should be fairly straightforward so going ahead with landing this (and tests) optimistically.
|
@inexorabletash looks like it hasn't even started. @jgraham we've had this issue before in #14165 which was then resolved, but now it's happening again. Do you know of ongoing Taskcluster issues? The easiest way to retrigger all CI systems is to close and reopen a PR, so I'll do that. If Taskcluster still doesn't start, we should just admin merge. |
|
This is concerning, there's still no "Details" link for Taskcluster, so it hasn't told GitHub about any ongoing run. @jgraham, absent that, is there any way to figure out if Taskcluster started? |
|
Admin-merge pls? |
|
Given that even the close-reopen trick didn't work, I'm admin-merging this. Debugging the infra shouldn't block developers' work. |
* cursor.request * More detailed test, testing the various different kinds of cursor. * Using unreached_func
Define new |request| attribute on IDBCursor. Discussed in #255 WPT PR ready to land: web-platform-tests/wpt#15820 Implementations pending, but this should be fairly straightforward so going ahead with landing this (and tests) optimistically.
No description provided.