nix-shell: don't use XDG_RUNTIME_DIR if TMPDIR is unset #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDG_RUNTIME_DIR isn't meant for possibly-large build processes; it's mostly meant for small sockets, named pipes, and other IPC mechanisms. As a result it's limited in size on many systems, and so using it as a temporary directory (by setting TMPDIR to it) will cause some test and build processes to fail when they try to use more space than is available in XDG_RUNTIME_DIR. For example, XDG_RUNTIME_DIR is limited to 100MB on an older Debian system, and some build and test processes try to use several GB of space for temporary artifacts; these failures are spurious, and can be avoided if we just default directly to /tmp instead of trying to default to XDG_RUNTIME_DIR first.
lheckemann
approved these changes
Mar 21, 2019
|
There is a discussion in #2957 |
|
If this PR is re-resolved can this get merged? |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XDG_RUNTIME_DIR isn't meant for possibly-large build processes; it's
mostly meant for small sockets, named pipes, and other IPC
mechanisms. As a result it's limited in size on many systems, and so
using it as a temporary directory (by setting TMPDIR to it) will cause
some test and build processes to fail when they try to use more space
than is available in XDG_RUNTIME_DIR.
For example, XDG_RUNTIME_DIR is limited to 100MB on an older Debian
system, and some build and test processes try to use several GB of
space for temporary artifacts; these failures are spurious, and can be
avoided if we just default directly to /tmp instead of trying to
default to XDG_RUNTIME_DIR first.