HTML: mutating the style element #15871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
foolip
approved these changes
Mar 15, 2019
html/semantics/document-metadata/the-style-element/mutations.window.js
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
annevk
force-pushed
the
annevk/style-element-mutations
branch
from
223b2ba
to
15f84a8
Compare
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Dec 5, 2019
It needs to be "children changed steps" as the various consumers appear to react to changes of all sorts. Tests: web-platform-tests/wpt#15871. This builds on work started in #732 and will further refine that eventually.
foolip
approved these changes
Dec 6, 2019
html/semantics/document-metadata/the-style-element/mutations.window.js
Outdated
Show resolved
Hide resolved
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Dec 6, 2019
It needs to be "children changed steps" as consumers appear to react to changes of all sorts. Tests: web-platform-tests/wpt#15871. This builds on work started in #732 and will further refine that eventually. Meta follow-up: #802.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this for whatwg/dom#732 (comment) since I didn't really trust the current abstractions we have in place. And we also haven't tested them as I traced in https://freenode.logbot.info/whatwg/20190315#c2058477. So this is an initial test before I call it a week to show there's a problem with the standard (all browsers fail this test and change the style sheet upon insertion of a
Commentnode).cc @domenic @nox