Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 18.09 php updates #57651

Merged
merged 2 commits into from Mar 14, 2019
Merged

Release 18.09 php updates #57651

merged 2 commits into from Mar 14, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 14, 2019

Motivation for this change

Backport of php updates from #57066

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor Author

etu commented Mar 14, 2019

@GrahamcOfBorg build php71 php72

@globin
Copy link
Member

globin commented Mar 14, 2019

Could you please cherry-pick with -x

@Izorkin @etu
php71: 7.1.26 -> 7.1.27
6cdf642 
(cherry picked from commit 6272753)
@Izorkin @etu
php72: 7.2.15 -> 7.2.16
1849e96 
(cherry picked from commit c6290e3)
@etu etu force-pushed the release-18.09-php-updates branch from b8b55f9 to 1849e96 Compare March 14, 2019 18:23
@etu
Copy link
Contributor Author

etu commented Mar 14, 2019

@globin oh damn, forgot about that again. Fixed in both PR's.

@xeji xeji merged commit 8252eae into NixOS:release-18.09 Mar 14, 2019
@etu etu deleted the release-18.09-php-updates branch March 14, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@etu @globin @GrahamcOfBorg @xeji @Izorkin