Skip to content

pythonPackages.weboob: add pyqt5 as native input #57653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2019
Merged

pythonPackages.weboob: add pyqt5 as native input #57653

merged 2 commits into from
Mar 15, 2019
+15 −22

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Address @dotlambda feedback for #57555 after merge

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace
pythonPackages.weboob: add pyqt5 as native input
7267961 
Didn't notice it wasn't there. This should make it so we
don't have to set the environment variable anymore.
@worldofpeace worldofpeace requested a review from dotlambda March 14, 2019 17:41
@worldofpeace worldofpeace requested a review from FRidh as a code owner March 14, 2019 17:41
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 14, 2019
@worldofpeace
Copy link
Contributor Author

Port to stable so since the last change fixed build, and this makes things nicer.

@GrahamcOfBorg GrahamcOfBorg requested a review from primeos March 14, 2019 18:17
@worldofpeace
python.pkgs.google_api_python_client: conditionally override for pyth…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fb2af2a 
…on2.7
@dotlambda dotlambda force-pushed the google-api-python-client branch from 50fc89c to fb2af2a Compare March 15, 2019 09:18
@dotlambda
Copy link
Member

I changed it a tiny bit by using old.src.override.

@dotlambda dotlambda merged commit 6339f0b into NixOS:master Mar 15, 2019
@dotlambda
Copy link
Member

cherry picked in 497b023 and 9fa2a21

@worldofpeace
Copy link
Contributor Author

I changed it a tiny bit by using old.src.override.

Nice, more people should do it like that 👍

@worldofpeace worldofpeace deleted the google-api-python-client branch March 15, 2019 10:15
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@FRidh FRidh

@primeos primeos

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @dotlambda @samueldr @GrahamcOfBorg