Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1d6ad6befe42
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 54258e459fa6
Choose a head ref
  • 7 commits
  • 5 files changed
  • 4 contributors

Commits on Mar 13, 2019

  1. lightdm_gtk_greeter: fix configureFlags to not be one long string

    For whatever reason, setting `configureFlagsArray` causes
    the configure invocation to escape spaces between parameters:
    
    configure flags: --disable-static --disable-dependency-tracking --prefix=/nix/store/4bn8dsr743dp0g5j020jf8why5hkld3p-lightdm-gtk-greeter-2.0.6 --localstatedir=/var\ --sysconfdir=/etc\ --disable-indicator-services-command\ --enable-at-spi-command=/nix/store/li9bsxl8qja8qw0pa70xd572gw5hqsdm-at-spi2-core-2.30.1/libexec/at-spi-bus-launcher\ \ --launch-immediately
    
    This actually doesn't break the build (!) but it does break
    lightdm pretty badly for me and it's not hard to imagine why :).
    
    Instead, use configureFlags as normal but just append the command
    in `preConfigure` directly, so we can preserve the space.
    dtzWill committed Mar 13, 2019
    Copy the full SHA
    7971975 View commit details
  2. Copy the full SHA
    006a699 View commit details
  3. Merge pull request #57560 from dtzWill/fix/lightdm-gtk-greeter-config…

    …ureFlags
    
    lightdm_gtk_greeter: fix configureFlags to not be one long string
    dtzWill authored Mar 13, 2019
    Copy the full SHA
    88cd06d View commit details
  4. LTS Haskell 13.12

    peti committed Mar 13, 2019
    Copy the full SHA
    c187591 View commit details
  5. hackage-packages.nix: automatic Haskell package set update

    This update was generated by hackage2nix v2.14.2 from Hackage revision
    commercialhaskell/all-cabal-hashes@9fb5246.
    peti committed Mar 13, 2019
    Copy the full SHA
    8a0d165 View commit details
  6. Copy the full SHA
    bbf5431 View commit details
  7. Copy the full SHA
    54258e4 View commit details
Loading