solaar: 2018-02-02 -> 2019-01-30 + udev rules inclusion #57592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverca22
reviewed
Mar 13, 2019
|
|
||
| mkdir -p $out/lib/udev/rules.d | ||
| for f in rules.d/*.rules; do | ||
| cp "$f" $out/lib/udev/rules.d/ |
There was a problem hiding this comment.
what about cp -r rules.d $out/lib/udev ?
There was a problem hiding this comment.
there's an install.sh in the directory :)
There was a problem hiding this comment.
ah, then it would be cp rules.d/*.rules $out/lib/udev/rules.d/
Drops unused namePrefix, uses pname/version.
|
Also took the opportunity to cleanup using pname/version and removing a now unused attribute. From nixpkgs manual:
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Includes the udev rules in the solaar package. This allows the following to work.
In addition, update to the latest commit.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)