Oh, also asking for permission to backport to 19.03 as nobody is probably using the old options yet.

Looking pretty awesome! I've become a fan of this approach after @infinisil explained the benefits to me as well, but I think database should still have nixos options so you can do passwordFile. I'd also argue for nixos options for the database because it's nice to abstract that away from the user. For this type of application database is not optional so it's nice to be able to provide the options for the user without requiring them to read any application specific documentation. Keeping users as close to services.appname.enable = true; and they have a working application should be the goal, not having to read application documentation unless they need something out of the ordinary.

What's your opinion about database options remaining nixos options?

@aanderse There is not really a way for passwordFile because sadly, ini files don't support includes.
Exposing the database stuff to the user sounds appealing, but I don't really see an upside. The key names are almost the same and the guidance the user gets by getting errors when i.e. using invalid field names is not it imo.

I see your point about passwordFile option. I suppose the other possibility would be to execute a script like this

@aanderse No - this doesn't work either. Trust me, if it was possible easily, I would have done it. Ini files neither have a way to include other files nor a way to execute arbitrary code. What you recommend is probably something like using sed to place the password into the configuration file - perhaps in the PreStart of the php-fpm pool. This requires a lot of code, makes the the entire module more unclear, and solves a problem that doesn't even exist when using the non-nix way (resources = null;) to specify the resources. I even mentioned the problem with the password in the documentation of the option, so people will be aware about the problem. The only sane solution is adding passwordFile support to the upstream icingaweb2, but I don't have time for that.

Understood. Yeah it isn't a trivial amount of work to put that in a preStart.

Looking good!

@infinisil Is there a way this will get into 19.03? Otherwise, I'd remove the module on the 19.03 branch so people don't start relying on a module that will change in the next release.

Backported in 8569d30 :)

Thank you so much!